Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @niklasberglund)

.github/workflows/android-app.yml line 457 at r2 (raw file):

      - name: Run instrumented test script
        if: ${{ matrix.test-repeat != 0 }}
        timeout-minutes: ${{ fromJSON(steps.calculate-timeout.outputs.timeout) }}

Do we need to parse these timeouts from json?

Code quote:

fromJSON

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @albin-mullvad)

.github/workflows/android-app.yml line 457 at r2 (raw file):
It does look very odd, but fromJSON can be used to convert string to number. And the value for timeout-minutes cannot be a numerical string.

"For numerical comparison, the fromJSON() function can be used to convert a string to a number"

https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/evaluate-expressions-in-workflows-and-actions

Reviewable status: complete! all files reviewed, all discussions resolved

.github/workflows/android-app.yml line 457 at r2 (raw file):

Alright, sounds good! 👍